Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Enable extension on this domain" doesn't show whether it's enabled #1509

Closed
mehul0810 opened this issue Sep 5, 2018 · 1 comment · Fixed by fregante/webext-permission-toggle#8 or #1774
Labels
enhancement enterprise Related to GitHub Enterprise only help wanted Please! ♥︎ Particularly useful features that everyone would love!

Comments

@mehul0810
Copy link

Proposed Solution

I think by default the extension should be enabled for github.com domain and the Enable Refined Github on this domain option on right clicking should appear on other domains only. Also, if a particular domain has enabled the extension then the option should say Disable Refined GitHub on this domain and clicking on that should disable extension on that domain.

image

@fregante
Copy link
Member

fregante commented Sep 5, 2018

RGH is obviously already enabled on GitHub.com

What you're suggesting however is good. The contextMenu API lets us add a checkmark next to the item, so that would be a good way to show where it's enabled.

I haven't made this change because it means that the contextMenu needs to be instantiated for each tab (or something like that) instead of once.

Feel free to add the checkmark and thus the ability to disable the domain as well to the original module: https://github.com/bfred-it/webext-domain-permission-toggle

I opened an issue there: fregante/webext-permission-toggle#4

@sindresorhus sindresorhus added enhancement help wanted enterprise Related to GitHub Enterprise only labels Nov 7, 2018
@fregante fregante added the Please! ♥︎ Particularly useful features that everyone would love! label Jan 17, 2019
@fregante fregante changed the title Enable/Disable extension on this domain is not working properly "Enable extension on this domain" doesn't show whether it's enabled Feb 13, 2019
@fregante fregante reopened this Aug 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement enterprise Related to GitHub Enterprise only help wanted Please! ♥︎ Particularly useful features that everyone would love!
3 participants