Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show conflict marker in PR list #1593

Closed
Turbo87 opened this issue Oct 18, 2018 · 5 comments · Fixed by #2310
Closed

Show conflict marker in PR list #1593

Turbo87 opened this issue Oct 18, 2018 · 5 comments · Fixed by #2310

Comments

@Turbo87
Copy link
Contributor

Turbo87 commented Oct 18, 2018

We already show the CI and review status in the PR overview. It would be nice to also have a marker that shows if a PR is currently blocked due to unresolved merge conflicts.

@fregante
Copy link
Member

You want to show a marker on this list, correct?

https://github.com/sindresorhus/refined-github/pulls

We already show the CI and review status in the PR overview

FYI GitHub does that natively, not us.

This can be done via joint GraphQL API call: https://developer.github.com/v4/object/pullrequest/#mergeable

@Turbo87
Copy link
Contributor Author

Turbo87 commented Oct 22, 2018

You want to show a marker on this list, correct?

sindresorhus/refined-github/pulls

yes, correct

FYI GitHub does that natively, not us.

I see, it's sometimes hard to figure out what GitHub improved and what comes from the extension 😉

@sindresorhus
Copy link
Member

sindresorhus commented Nov 7, 2018

Sounds useful. PR welcome :)

Please also suggest the feature to GitHub: https://github.com/contact

@felixfbecker
Copy link

I'd love this. Dependency upgrade PRs often conflict after merging one of them, and it's so annoying to go through the list just to see that many are conflicting and are awaiting an automated rebase.

@Esemesek
Copy link
Contributor

Esemesek commented Aug 6, 2019

I'd like to implement this feature. Already worked a bit on this and I think I should be able to create a PR sometime this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

5 participants