Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to rich diffs for SVG files #1599

Closed
waldyrious opened this issue Oct 26, 2018 · 5 comments · Fixed by #1932
Closed

Default to rich diffs for SVG files #1599

waldyrious opened this issue Oct 26, 2018 · 5 comments · Fixed by #1932
Labels
enhancement 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted

Comments

@waldyrious
Copy link
Contributor

waldyrious commented Oct 26, 2018

Issuehunt badges

When SVG files are edited, usually the rich diff (rendered image) is more useful/desirable than textual diff.

This is particularly useful when such files are edited in an editor rather than by hand, since the changes are usually extensive enough to go over the size limit for showing the diff automatically, so neither the code nor the rich diff are shown by default (the "Load diff" link is shown instead). See for example pretty much any PR at icon repos, such as https://github.com/elementary/icons/pulls.

idasbiste earned $40.00 by resolving this issue!

@sindresorhus
Copy link
Member

I agree, this would be useful. Also make sure you request it from GitHub themselves: https://github.com/contact

@IssueHuntBot
Copy link

@IssueHunt has funded $40.00 to this issue.


@issuehunt-oss issuehunt-oss bot added the 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt label May 3, 2019
@IssueHuntBot
Copy link

@sindresorhus has rewarded $36.00 to @idasbiste. See it on IssueHunt

  • 💰 Total deposit: $40.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $4.00

@dmitryGolikov
Copy link

It would be nice to display a rich diff in commits by default to.

@waldyrious
Copy link
Contributor Author

Cross-referencing #2041, since this feature was disabled in ba5d2df due to issues with the current implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted
Development

Successfully merging a pull request may close this issue.

5 participants