Wait for successful checks when using administrator privileges

[LeoColomb]

When using administrator privileges to merge a pull request, the wait for successful checks is not respected and the PR is directly merge.

[fregante]

This is probably because the selector is different and the button click isn’t caught. Can you copy the whole block’s HTML and paste it here? Or maybe try submitting a PR

[fregante]

The feature wasn't working correctly on regular merges too, c6a3bd2 fixes that.

Can you wait for tomorrow's RGH release and see if that works for you already?

[LeoColomb]

You are too quick to let me submit a PR! 😉
The HTML change should be recent, I use it with success on a regular merge not so long ago.
But sure, I'll try as soon as the release is published!
Thanks! 👍

[LeoColomb]

👌

[fahhem]

This seems to be happening again/still:

[CAFxX]

Confirm, just happened to me again:

[fregante]

I finally tested this. The checkbox appears but once "Confirm squash and merge" is pressed it will still be awaited as usual

[drewlustro]

This isn't working for me. PR merged without waiting for successful checks :\

[fregante]

Let's disable the feature when it detects this setup since it's useless here:

• if the PR requires administrator privileges, it means the repo has branch restrictions, so it means you can add the additional "status checks" requirement
• if you're an administrator, it means you can enable the native automerge autonomously as well

[cheap-glitch]

@fregante Can we set up something to test this? If not, we need at least some relevant HTML to make a matching exclude or something

[fregante]

To test this, you need to be the administrator in a repo. If you're an admin on the sandbox:

• create a branch
• add branch protections to that branch
• open a PR to that branch

Otherwise you can create any new repos and do that