Add feature remove-diff-signs

[fregante]

Closes #1464

It can be disabled 🎈

Test

Any commits on https://github.com/sindresorhus/refined-github/commits/master
Any reviewed block on #1783
Full diff on https://github.com/sindresorhus/refined-github/pull/1783/files

  inline diffs
- minus
+ plus

diff --git a/foo.c b/foo.c
index 30cfd169..8de130c2 100644
--- a/foo.c
+++ b/foo.c
@@ -1,5 +1,5 @@
 #include <string.h>

 int check (char *string) {
-    return !strcmp(string, "ok");
+    return (string != NULL) && !strcmp(string, "ok");
 }

Question

Where else do commits appear

Screenshot

[fregante]

This is ready to merge, except I need suggestions on how to handle diffs and patches. This is how it looks currently.

Notes:

• ```diff and ```patch are indistinguishable from the dom
• patch will show those ---/+++ at the start and they're not removable
• in this case, -/+ are hidden but copy-pastable

Perhaps we should leave inline diffs/patches untouched.

[sindresorhus]

Perhaps we should leave inline diffs/patches untouched.

Yeah, probably best. I don't think people would realize they could still copy-paste it and use it as a .diff with Git if they don't see the + and -.

[sindresorhus]

The downside of hiding the diff symbols is that it now looks like all code is indented. Should we also move it to the left?

[sindresorhus]

Where else do commits appear

Change suggestions: sindresorhus/package-json#51 (comment) (Works)

[fregante]

The downside of hiding the diff symbols is that it now looks like all code is indented. Should we also move it to the left?

I'm hesitant to do that. Not all code blocks are indented the same way (some use padding-left, some plain text nodes) and other extensions might expect the space to be there:

Remember what we had to go through with the previous remove-diff-signs

[sindresorhus]

Remember what we had to go through with the previous remove-diff-signs

Yeah... But that was slightly different from what I can remember. Then, we actually replaced some nodes. This would only be CSS changes.

[sindresorhus]

Let's try it like this now and see how we feel about it after a while.

[nesl247]

Commenting here since I was about to open a bug about it. The new spacing is much worse IMO than having the symbols. The spacing causes me to believe everything is formatted badly when reading the diffs and I have to remember that the space is there because of this feature.