Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"close and comment" button float left, Easy to make a mistake #1915

Closed
elzup opened this issue Apr 10, 2019 · 4 comments
Closed

"close and comment" button float left, Easy to make a mistake #1915

elzup opened this issue Apr 10, 2019 · 4 comments
Labels
enhancement help wanted small Issues that new contributors can pick up under discussion

Comments

@elzup
Copy link

elzup commented Apr 10, 2019

This is feedback. And the same record for those in need. [transrated by google]
これはフィードバックです。そして同じように困っている人のための記録です。

Version
19.4.7.1857

It feels like the wrong operation is increased by changing the button position.
ボタン位置の変更によってむしろ誤って操作することが増えたように感じます。

Code in.

https://github.com/sindresorhus/refined-github/blob/0b6c7330c21f8570519143ad3d0decc328d4db47/source/content.css#L476-L478

For now, I turned off like this.
とりあえず私はこのようにオフにしました。
Extensions

@fregante
Copy link
Member

Good idea. We already do this for the “Cancel” buttons when leaving comments and for “Cancel review”

@fregante fregante added small Issues that new contributors can pick up help wanted and removed under discussion labels Apr 10, 2019
@fregante
Copy link
Member

Ah, I misunderstood. We already use float:left to avoid mistakes. What if we colored the button red? Or maybe just the text

@elzup
Copy link
Author

elzup commented May 7, 2019

GitHub changes works for me. and reconsidered that float: left; is better.
Thank you for the discussion.

WIP__Add_trigger_modal_by_gn-spawn·Pull_Request__47·_elzup_farm-controller-front

@elzup elzup closed this as completed May 7, 2019
@fregante
Copy link
Member

fregante commented May 7, 2019

Thanks for following up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help wanted small Issues that new contributors can pick up under discussion
Development

No branches or pull requests

2 participants