Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide milestone drag icon when no permission #1918

Closed
jerone opened this issue Apr 10, 2019 · 1 comment · Fixed by #1980
Closed

Hide milestone drag icon when no permission #1918

jerone opened this issue Apr 10, 2019 · 1 comment · Fixed by #1980
Labels
enhancement help wanted small Issues that new contributors can pick up

Comments

@jerone
Copy link
Contributor

jerone commented Apr 10, 2019

image

The icon to allow dragging of milestone issues is shown when you don't have permissions to edit milestones. Why not just hide this distracting functionality for users without milestone edit permissions.

      <div class="d-table-cell v-align-top pt-2 pr-1 text-gray-dark Box-row--drag-button  pl-2" style="width:21px;"> <!-- To line up with checkbox in filter bar -->
          <span class="tooltipped tooltipped-ne tooltipped-multiline" aria-label="You do not have permission to edit this milestone." style="/*! display: none; */">
            <svg class="octicon octicon-grabber v-align-text-bottom" style="width: 12px" viewBox="0 0 8 16" version="1.1" width="8" height="16" aria-hidden="true"><path fill-rule="evenodd" d="M8 4v1H0V4h8zM0 8h8V7H0v1zm0 3h8v-1H0v1z"></path></svg>
          </span>
      </div>

It can be linked to the aria-label-attribute with the specific text "You do not have permission to edit this milestone.".

Test url: https://github.com/ForkIssues/TrackerWin/milestone/9

@sindresorhus
Copy link
Member

Accepted. PR welcome :)

@sindresorhus sindresorhus added small Issues that new contributors can pick up help wanted and removed under discussion labels Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help wanted small Issues that new contributors can pick up
Development

Successfully merging a pull request may close this issue.

2 participants