-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add oldest-newest-commit-list
feature
#1922
Add oldest-newest-commit-list
feature
#1922
Conversation
How often do you need to reach the first commit though? |
Personally, I need that often when trying to investigate something in open source projects. The blame feature isn't enough for me. |
I could see the use-case for "Newest" to go back to the first page, but I don't think I ever needed to see the oldest commits. And I don't think either are useful enough to make the default navigation noisy. I think these would be better as either keyboard shortcuts or links somewhere that are not visually disturbing the normal navigation. |
The links could be more discrete chevrons «»
There’s a big implementation difference between Newest and Oldest, if we decide that Oldest isn’t worth the hassle (2 API calls on every Commits page), we could just add a Newest link |
Well, I'd love to have the oldest button. |
Please run this to delete the tags from your fork and locally, we keep pulling them from your fork and pushing them to this repo (we no longer use tags) git tag -d $(git tag | grep -E '.')
git ls-remote --tags --refs origin | cut -f2 | xargs git push origin --delete |
ebeb8de
to
f5228c7
Compare
f5228c7
to
5a1d4dc
Compare
I did that, is it ok now? |
It is thanks! And sorry if it sounded like it was your fault, I worded it badly |
That's fine. :) Really appreciate your hard work! |
Please let me know what's your decision about this feature, going forward with both of the buttons (and just change the layout) or just close this PR? |
I'll close this for now and I'll only implement the Newest button |
fwiw I wish Oldest button got merged. I frequently just want to see how old a project is and where it started off out of sheer curiosity. |
@corysimmons how old is already there |
@yakov116 I can't seem to find it. :\ |
@corysimmons its on the repo bar. It was one of the last features added #2560 |
Ah, that explains why I missed it. Thank you so much. |
This feature adds two new links (Oldest and Newest) to the commit list pagination.
The
api3
url is now exposed because I didn't want to make too many changes to supporthead
requests.Test
https://github.com/sindresorhus/refined-github/commits/master
Before
After