Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add oldest-newest-commit-list feature #1922

Conversation

eranshmil
Copy link

@eranshmil eranshmil commented Apr 12, 2019

This feature adds two new links (Oldest and Newest) to the commit list pagination.
The api3 url is now exposed because I didn't want to make too many changes to support head requests.

Test

https://github.com/sindresorhus/refined-github/commits/master

Before

image

After

image

@fregante
Copy link
Member

How often do you need to reach the first commit though?

@eranshmil
Copy link
Author

Personally, I need that often when trying to investigate something in open source projects. The blame feature isn't enough for me.

@sindresorhus
Copy link
Member

I could see the use-case for "Newest" to go back to the first page, but I don't think I ever needed to see the oldest commits. And I don't think either are useful enough to make the default navigation noisy. I think these would be better as either keyboard shortcuts or links somewhere that are not visually disturbing the normal navigation.

@sindresorhus
Copy link
Member

Maybe they could be small faded out links, not buttons, in positions like this:

Screen Shot 2019-04-17 at 20 56 00

@fregante
Copy link
Member

The links could be more discrete chevrons «»

Newest is technically already accessible by selecting the current branch in the branch selector (two clicks though)

There’s a big implementation difference between Newest and Oldest, if we decide that Oldest isn’t worth the hassle (2 API calls on every Commits page), we could just add a Newest link

@eranshmil
Copy link
Author

Well, I'd love to have the oldest button.
But if you think it's not worth the hassle, I don't think there's a reason to add only the newest button.

@fregante
Copy link
Member

Please run this to delete the tags from your fork and locally, we keep pulling them from your fork and pushing them to this repo (we no longer use tags)

git tag -d $(git tag | grep -E '.')
git ls-remote --tags --refs origin | cut -f2 | xargs git push origin --delete

@eranshmil eranshmil force-pushed the feat/oldest-newest-commit-list branch from ebeb8de to f5228c7 Compare April 19, 2019 07:02
@eranshmil eranshmil force-pushed the feat/oldest-newest-commit-list branch from f5228c7 to 5a1d4dc Compare April 19, 2019 07:52
@eranshmil
Copy link
Author

Please run this to delete the tags from your fork and locally, we keep pulling them from your fork and pushing them to this repo (we no longer use tags)

git tag -d $(git tag | grep -E '.')
git ls-remote --tags --refs origin | cut -f2 | xargs git push origin --delete

I did that, is it ok now?

@fregante
Copy link
Member

It is thanks! And sorry if it sounded like it was your fault, I worded it badly

@eranshmil
Copy link
Author

It is thanks! And sorry if it sounded like it was your fault, I worded it badly

That's fine. :)

Really appreciate your hard work!

@eranshmil
Copy link
Author

eranshmil commented Apr 23, 2019

Well, I'd love to have the oldest button.
But if you think it's not worth the hassle, I don't think there's a reason to add only the newest button.

Please let me know what's your decision about this feature, going forward with both of the buttons (and just change the layout) or just close this PR?
Thanks!

@fregante
Copy link
Member

I'll close this for now and I'll only implement the Newest button

@fregante fregante closed this Apr 24, 2019
@corysimmons
Copy link

fwiw I wish Oldest button got merged. I frequently just want to see how old a project is and where it started off out of sheer curiosity.

@yakov116
Copy link
Member

@corysimmons how old is already there

@corysimmons
Copy link

@yakov116 I can't seem to find it. :\

@yakov116
Copy link
Member

yakov116 commented Dec 20, 2019

@corysimmons its on the repo bar. It was one of the last features added #2560

@corysimmons
Copy link

Ah, that explains why I missed it. Thank you so much.

@refined-github refined-github locked as resolved and limited conversation to collaborators Mar 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

None yet

5 participants