Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable update-pr-from-base-branch on forks #2168

Closed
fregante opened this issue Jun 23, 2019 · 1 comment
Closed

Enable update-pr-from-base-branch on forks #2168

fregante opened this issue Jun 23, 2019 · 1 comment
Labels
enhancement help wanted

Comments

@fregante
Copy link
Member

fregante commented Jun 23, 2019 •
edited

GitHub recently added a new API endpoint for this specific operation and it works across forks: https://developer.github.com/v3/pulls/#update-a-pull-request-branch

It would replace this:

https://github.com/sindresorhus/refined-github/blob/b3e38ad58c87fd1ab927e27368cf3c836aa29041/source/features/update-pr-from-base-branch.tsx#L19-L29

They don't have an API to verify whether the PR is up to date, so I sent them feedback to ask for one. For now, the API we're using for this should work across forks already.
@fregante
Copy link
Member Author

fregante commented Aug 3, 2019

Wow I opened this same issue 3 weeks before: #2097

@fregante fregante closed this as completed Aug 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fregante