Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pr-branch-auto-delete should be disabled by default #2267

Closed
cmccandless opened this issue Jul 23, 2019 · 2 comments
Closed

pr-branch-auto-delete should be disabled by default #2267

cmccandless opened this issue Jul 23, 2019 · 2 comments

Comments

@cmccandless
Copy link

I discovered the addition of pr-branch-auto-delete (#2186) when I noticed that branches were being deleted without my explicit action. The feature functions as designed, but as this affects user repositories directly (and not just how they are presented), this is a feature that should not be enabled by default.

@fregante
Copy link
Member

fregante commented Jul 23, 2019

Under what circumstances would you prefer to keep the branch?

The feature is enabled by default because: #1024 (comment)

@sindresorhus
Copy link
Member

Also note that the action is easily reversible.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

3 participants