Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore "Sticky Issues Header" feature #2280

Closed
fregante opened this issue Jul 29, 2019 · 2 comments · Fixed by #2295
Closed

Restore "Sticky Issues Header" feature #2280

fregante opened this issue Jul 29, 2019 · 2 comments · Fixed by #2295
Labels
bug help wanted small Issues that new contributors can pick up

Comments

@fregante
Copy link
Member

fregante commented Jul 29, 2019

It was added in #1311 but I can't find it anymore.

Anyone remember if it was removed for any reason? cc @tommoor @hkdobrev @yakov116

Anyway this is a quick fix if anyone wants to pick it up.

@fregante fregante added bug under discussion small Issues that new contributors can pick up help wanted labels Jul 29, 2019
@sharkykh
Copy link
Contributor

sharkykh commented Jul 29, 2019

$ git log -S'/* Sticky table header on issues list */' --pretty=format:'%h %an -- %s -- %ad'
a9ec680 Waseem Dahman -- Fix sticky file header tooltips (#1581) -- 2018-11-06 17:43:48 +0200
dd8760b Tom Moor -- 📌Sticky Issues Header (#1311) -- 2018-05-10 20:13:57 +0300

a9ec680 combined this and the sticky file headers features together, and changed the comment from /* Sticky table header on issues list */ to /* Sticky file and table headers */

$ git log -S'/* Sticky file and table headers */' --pretty=format:'%h %an -- %s -- %ad'
76cc04d Federico Brigante -- Drop feature `make-headers-sticky` -- 2019-03-18 19:18:55 +0200
a9ec680 Waseem Dahman -- Fix sticky file header tooltips (#1581) -- 2018-11-06 17:43:48 +0200

76cc04d removed both sticky issue list headers and sticky file headers (the latter was implemented by GitHub).

To whoever picks this up,
keep in mind that dd8760b (#1311) also had a bugfix commit later: 4f43ef6 (#1318)
And maybe it should have an option to disable - so, have a .tsx file to inject a rgb-sticky-header class, like hide-watch-and-fork-count does.

@fregante
Copy link
Member Author

Excellent! Thank you so much for that!

@fregante fregante changed the title "Sticky Issues Header" feature missing Restore "Sticky Issues Header" feature Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug help wanted small Issues that new contributors can pick up
Development

Successfully merging a pull request may close this issue.

2 participants