Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop pr-branch-auto-delete feature #2289

Closed
FloEdelmann opened this issue Jul 31, 2019 · 3 comments
Closed

Drop pr-branch-auto-delete feature #2289

FloEdelmann opened this issue Jul 31, 2019 · 3 comments

Comments

@FloEdelmann
Copy link
Member

It was implemented by GitHub: https://github.blog/changelog/2019-07-31-automatically-delete-head-branches-of-pull-requests/

On a repository's settings page, there is now a checkbox to enable the feature:

Screenshot_2019-07-31_13-53-31

@fregante
Copy link
Member

Lol that was fast!

cc @sindresorhus

@fregante
Copy link
Member

This is good, but their feature has a few big disadvantages:

  • it has to be enabled in each repo: our feature works everywhere.
  • it has to be enabled by the owner: if the owner doesn't enable it, collaborators won't benefit from it.

For this, I think we should still keep it.

I wish GitHub at least enabled it by default in forks, where our feature doesn't apply.

@sindresorhus
Copy link
Member

I agree, we should keep the feature. I have no intention of manually enabling that setting on 1000+ repos.

@fregante fregante closed this as completed Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants