[regression] PR scroll header breaks to multiple lines / overlaps content

[wearhere]

#2202 appears to be happening again, alas.

With the latest Refined GitHub, 19.7.30:

Without:

These screenshots show a particular commit selected but I can confirm that the bug happens on the files tab (e.g. /pull/7418/files) too.

[sharkykh]

Weird, I don't experience this.
Does anyone have a public PR where we can see it live?

[wearhere]

@sharkykh, sure, happens to me here: https://github.com/mixmaxhq/custody/pull/79/files

I do see that it doesn’t happen for all PRs, like doesn't happen for https://github.com/mixmaxhq/custody/pull/78/files —maybe it depends on the length of the PR, that one's shorter.

[sharkykh]

I'm still not experiencing this even with your PR.
Maybe it's related to screen resolution or Windows' display scaling? I'm on 1920x1080 at 100% scaling.

[wearhere]

Hm… I'm on Chrome 75.0.3770.142 on OS X 10.14.5, with my resolution at 1680x1050 and the webpage at 100% scaling. The problem also happens for me at 1920x1200.

[jerone]

Can you check the 24em is actually applied?

Any errors in the console?

[wearhere]

Thanks for your help thus far folks.

The 24em does seem to be applied and it still breaks:

One error in the console:

[sharkykh]

Error is unrelated: #2292

[jerone]

The 24em does seem to be applied and it still breaks:

So, what is your magic number for the title?

And you are not zoomed-in?

[fregante]

Can confirm, Firefox/macOS and see the issue. 23em works, but the suggestions in the previous thread still apply (shorter button)

Alternatively we could use flexbox to ensure it works for every size, but last time I tried it wouldn't shrink due to the white-space: nowrap needed for the ellipsis. You're welcome to try

[wearhere]

@jerone

The 24em does seem to be applied and it still breaks:

So, what is your magic number for the title?

Do you mean, what em causes the problem to go away? Seems like 23em works, like @fregante writes above.

And you are not zoomed-in?

No.

[fregante]

Additional button breaks it even more:

[fregante]

Again I'd suggest:

• restoring the regular dropdown
• dropping its "apply and reload" button so it requires one fewer click
• perhaps opening the dropdown on hover

There's already a keyboard shortcut to toggle the whitespace.

I enjoy the diff buttons being easily accessible but I prefer a non-broken site. This feature has been causing the same issue for years

[nesl247]

Just ran into this myself. Is there a feature we can disable to fix this temporarily?

[kidonng]

@nesl247 try disable faster-pr-diff-options feature

[felixfbecker]

See this all the time :/

[fregante]

I disabled this feature in PRs because its an ugly bug that many reported. Continue the discussion in #2597