Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options can no longer be disabled for custom domains #2304

Closed
Xapphire13 opened this issue Aug 5, 2019 · 1 comment
Closed

Options can no longer be disabled for custom domains #2304

Xapphire13 opened this issue Aug 5, 2019 · 1 comment
Assignees
Labels
bug enterprise Related to GitHub Enterprise only

Comments

@Xapphire13
Copy link

After a small amount of digging I think it's related to 703cc57.

Options are successfully disabled for github.com, but the on/off state is ignored for custom domains.

image

All of the above are true, despite my config looking like:

image

I have also tried selecting and configuring both github.com and custom domains in the drop down, to no avail.

@Xapphire13 Xapphire13 added the bug label Aug 5, 2019
@fregante fregante added the enterprise Related to GitHub Enterprise only label Aug 6, 2019
@fregante fregante self-assigned this Aug 6, 2019
@fregante
Copy link
Member

fregante commented Aug 6, 2019

Thanks for the report! I broke it in 9a6c65a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug enterprise Related to GitHub Enterprise only
Development

No branches or pull requests

2 participants