Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sticky-discussion-sidebar feature broken #2313

Closed
notlmn opened this issue Aug 8, 2019 · 3 comments · Fixed by #2314
Closed

sticky-discussion-sidebar feature broken #2313

notlmn opened this issue Aug 8, 2019 · 3 comments · Fixed by #2314

Comments

@notlmn
Copy link
Contributor

notlmn commented Aug 8, 2019

The .discussion-sidebar class doesn't exist anymore, will need to use #partial-discussion-sidebar to target the sidebar element instead.

image

@fregante
Copy link
Member

fregante commented Aug 8, 2019

This was changed last week, did they change class again? 🤔

@notlmn
Copy link
Contributor Author

notlmn commented Aug 8, 2019

That class existed on the element with the id mentioned above, but we always used the class to target the sidebar since the feature was originally introduced. It doesn't exist anymore on the page.

I think they're dropping classes for all the elements that already have an id. If that's the case, we should expect some more broken features.

@sharkykh
Copy link
Contributor

sharkykh commented Aug 8, 2019

Hi.
Actually, it looks like they made our job easier with this clean-up.
I will address this issue now.

Ref of the previous fix: #2294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants