Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alignment issue in Releases subnav #2325

Closed
fregante opened this issue Aug 13, 2019 · 3 comments · Fixed by #2332
Closed

Alignment issue in Releases subnav #2325

fregante opened this issue Aug 13, 2019 · 3 comments · Fixed by #2332
Labels
bug help wanted small Issues that new contributors can pick up

Comments

@fregante
Copy link
Member

Test url: https://github.com/sindresorhus/refined-github/releases

DOM as it appears:

<div class="subnav">
	<div class="d-flex flex-md-row flex-justify-between flex-md-items-center">
		<div class="subnav-links float-left" role="navigation">
			<a class="js-selected-navigation-item selected subnav-item" aria-current="page"
				data-selected-links="repo_releases /sindresorhus/refined-github/releases"
				href="/sindresorhus/refined-github/releases">Releases</a>
			<a class="js-selected-navigation-item subnav-item"
				data-selected-links="repo_tags /sindresorhus/refined-github/tags"
				href="/sindresorhus/refined-github/tags">Tags</a>

			<a class="js-selected-navigation-item subnav-item"
				data-selected-links="repo_packages /sindresorhus/refined-github/packages"
				href="/sindresorhus/refined-github/packages">Packages</a>
		</div>

		<div class="pt-2 pt-md-0">
			<span class="text-gray-light f6">
				<a href="/features/package-registry/signup">Sign up for the GitHub Package Registry</a><span
					class="lh-condensed ml-1 px-1 rounded-1 border border-green f6">Beta</span>
			</span>
		</div>
	</div>


	<div class="float-right hide-sm">
		<a href="/sindresorhus/refined-github/releases/new" class="btn">Draft a new release</a>
	</div>
	<div class="rgh-tags-dropdown float-right d-flex flex-shrink-0 flex-items-center">
		<details class="details-reset details-overlay select-menu branch-select-menu position-relative">
			<summary class="btn select-menu-button css-truncate" data-hotkey="w" title="Find tags" aria-haspopup="menu">Select
				tag&nbsp;</summary>
			<!-- tags list-->
		</details>
	</div>
</div>
@fregante
Copy link
Member Author

Apparently this is what it looks like without Refined GitHub. Awful too

@fregante
Copy link
Member Author

This seems to be the fix, but I don't know what's causing the issue in the first place. PR welcome to locate the troubling CSS and placing this next to it.

.subnav > :first-child {
	flex-grow: 1
}

@hardikmodha
Copy link
Contributor

Just noticed this issue as well. I'll push a fix tonight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug help wanted small Issues that new contributors can pick up
Development

Successfully merging a pull request may close this issue.

2 participants