Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty comment field displays unnecessary "please fill out this field" tooltip when hovered over in Firefox #2349

Closed
vrad-exe opened this issue Aug 18, 2019 · 5 comments · Fixed by #2375
Labels
enhancement help wanted small Issues that new contributors can pick up

Comments

@vrad-exe
Copy link

As stated in the title, this tooltip appears when mousing over the comment field while it is empty. I know how issue comments work, I don't need this appearing and obscuring my text every time I go to write a comment. This is something which happens in normal GitHub, so I was hoping Refined GitHub would be able to fix it. I guess that makes this a feature request?

This only happens in Firefox as far as I can tell, which is possibly why it seems to have gone unnoticed. It's definitely a part of the site itself though, and not the browser: this message will appear in Chrome, but only when hovering over the issue title field, and not the comment field. In that case it's not really a problem though, since that's the default focused text box and the tooltip appears low enough that it doesn't cover the text anyway.

Here's a screenshot of the tooltip in question.
image

@kidonng
Copy link
Member

kidonng commented Aug 18, 2019

The tip comes from required attribute of <textarea>, removing it when the comment field is empty will break GitHub's form validation and cause the comment button to be disabled.

...this message will appear in Chrome, but only when hovering over the issue title field, and not the comment field...

That's because the issue title field is a <input> with required attribute as well, but I have no idea why Chrome doesn't show the tip for <textarea>.

@fregante
Copy link
Member

Would adding a title='' attribute avoid the tooltip? If so, in both browsers, this can be added as a feature.

PR welcome

@fregante fregante added enhancement small Issues that new contributors can pick up help wanted labels Aug 22, 2019
@kidonng
Copy link
Member

kidonng commented Aug 22, 2019

@fregante Yes, works on both browsers

@vrad-exe
Copy link
Author

Not sure if I should open a new issue for this, but this now happens again in issue forms.

@vrad-exe
Copy link
Author

This has started happening again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help wanted small Issues that new contributors can pick up
Development

Successfully merging a pull request may close this issue.

3 participants