Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert changes for a single file doesnt work on private repos #2362

Closed
staabm opened this issue Aug 21, 2019 · 4 comments
Closed

revert changes for a single file doesnt work on private repos #2362

staabm opened this issue Aug 21, 2019 · 4 comments
Labels

Comments

@staabm
Copy link

staabm commented Aug 21, 2019

in a private repos I cannot 'revert changes of a single file'. I am getting a 'Revert failed - see console for details' message and the following error logs:

grafik

after adding the 'personal token' in the extensions settings it works as expected.

would be great to have a cleaner error message that I missed to configure the token

using 19.8.20 in google chrome 78

@staabm staabm added the bug label Aug 21, 2019
@kidonng
Copy link
Member

kidonng commented Aug 21, 2019

image
image

@staabm
Copy link
Author

staabm commented Aug 21, 2019

I am aware that ‚some features‘ require the token.

A simple console log error telling that the token is missing would be great for UX

@kidonng
Copy link
Member

kidonng commented Aug 21, 2019

If it's for great UX then we should use a snackbar or popup instead of console messages.
There are already messages telling you that token may be needed. But your screenshot doesn't contain the error message for revert-file feature.

(And "Personal token required for this feature" error for another feature can be seen in your screenshot)

@fregante
Copy link
Member

Indeed. The token error is already present in the console. We generally expect it to be there and don’t provide extra UI for such errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants