Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dim-bots dims human author commits #2517

Closed
nmussy opened this issue Nov 4, 2019 · 2 comments · Fixed by #2519
Closed

dim-bots dims human author commits #2517

nmussy opened this issue Nov 4, 2019 · 2 comments · Fixed by #2519
Labels
bug help wanted small Issues that new contributors can pick up

Comments

@nmussy
Copy link
Contributor

nmussy commented Nov 4, 2019

dim-bots (#2447) dims commits authored by humans, but committed by bots. See aws-cdk, which uses mergify:

image

@nmussy nmussy added the bug label Nov 4, 2019
@nmussy
Copy link
Contributor Author

nmussy commented Nov 4, 2019

I gave it a quick glance, and it doesn't look like there's any way to tell an author and committer user apart, except for the tags position. Something like this selector will have to be used:
.commit-author:not([href$="%5Bbot%5D"]):not([href$="renovate-bot"]) + .commit-author

@fregante
Copy link
Member

fregante commented Nov 5, 2019

I think it just needs :first-child to be added so it only hides commits that have a bot listed first

	const bots = select.all([
		/* Commits */
		'.commit-author[href$="%5Bbot%5D"]:first-child',
		'.commit-author[href$="renovate-bot"]:first-child',

		/* PRs */
		'.opened-by [href*="author%3Aapp%2F"]'
	].join());

@fregante fregante added small Issues that new contributors can pick up help wanted labels Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug help wanted small Issues that new contributors can pick up
Development

Successfully merging a pull request may close this issue.

2 participants