Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort commits topologically first instead of by author date #2548

Closed
graingert opened this issue Nov 18, 2019 · 3 comments
Closed

Sort commits topologically first instead of by author date #2548

graingert opened this issue Nov 18, 2019 · 3 comments
Labels
enhancement impossible Features requests that are impossible or impractical to implement

Comments

@graingert
Copy link

isaacs/github#386
Example URL: https://github.com/sindresorhus/refined-github/pull/2513/commits

@sindresorhus
Copy link
Member

I don't think we can easily do this as to correctly to it, we would have to sort across pages, which would be very difficult to implement correctly.


For anyone that wants this, please also send this feature request to GitHub: support@github.com

@graingert
Copy link
Author

That is a shame, the main place in want it is the next/previous buttons on the PR

@fregante
Copy link
Member

fregante commented Nov 30, 2019

Unless GitHub has a URL parameter to achieve this, we'd have to not only manage pagination, but also recreate the whole UI around the commits we fetch and sort from the API.

Closing as impossible to achieve (i.e. way out of Refined GitHub's scope)

@fregante fregante added the impossible Features requests that are impossible or impractical to implement label Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement impossible Features requests that are impossible or impractical to implement
Development

No branches or pull requests

4 participants