Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear PR merge commit description field #2564

Closed
fregante opened this issue Nov 22, 2019 · 1 comment · Fixed by #3003
Closed

Clear PR merge commit description field #2564

fregante opened this issue Nov 22, 2019 · 1 comment · Fixed by #3003
Labels
enhancement help wanted small Issues that new contributors can pick up

Comments

@fregante
Copy link
Member

On PRs, when squashing, the commit description is filled with every commit's title.

I think that if you squash, probably aren't interested in every commit's title and should therefore be dropped. If they're useful, maybe you should merge or rebase instead, IMHO.

Thoughts?

Perhaps we should just preserve a deduplicated list of Co-authored-by

Currently

Expected

@sindresorhus
Copy link
Member

I sometimes find it useful to be able to quickly scan what commits are included in the squash and I do think we should preserve a deduplicated list of co-authors. How about we present a list of commit titles underneath or something? So I can still scan it, but it's not included by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help wanted small Issues that new contributors can pick up
Development

Successfully merging a pull request may close this issue.

2 participants