Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR review "final report box" to show before merging #2579

Open
fregante opened this issue Nov 30, 2019 · 4 comments
Open

PR review "final report box" to show before merging #2579

fregante opened this issue Nov 30, 2019 · 4 comments

Comments

@fregante
Copy link
Member

fregante commented Nov 30, 2019

When about to merge PRs:

Screenshot 2019-11-30 at 16 44 43

we could show a final "report" box listing what's about to happen:

What else could this include?

@fregante
Copy link
Member Author

fregante commented Feb 28, 2020

full list of commits that will be merged/squashed/rebased

This would be a good start for this feature

@fregante fregante added the Please! ♥︎ Particularly useful features that everyone would love! label Aug 8, 2020
@fregante
Copy link
Member Author

  • issues/PRs that will automatically be closed (via closes #11 keyword) or if none will be closed

Actually I'd like to see this more. Sometimes new users forget to mark "closes X" correctly so it'd be good to see "No issues will be closed when merging this PR" as well as "X Y and Z will be closed after merging.

@fregante fregante removed the Please! ♥︎ Particularly useful features that everyone would love! label Aug 10, 2021
@rkrisztian
Copy link

rkrisztian commented Sep 12, 2023

I need the warnings or even merge checks for !squash and !fixup commits the most. I'm concerned that https://github.com/13rac1/block-fixup-merge-action still does not support merge queues, already has deprecation warnings and it has not received updates since 2021.

Edit: Plus I think it would be more ideal if it wasn't a GitHub Action that needed to check for such commits. It doesn't feel right if an action checks this. Commits are metadata, it's not really the responsibility of a pipeline execution to deal with them. A PR pipeline typically executes some build and tests, and if the check for commits is implemented wrongly, it won't be a separate check but will fail the PR pipeline prematurely just because there's a fixup commit that will be squashed once everything is ready for merge.

@cooljeanius
Copy link

I'm concerned that 13rac1/block-fixup-merge-action still does not support merge queues

I mean, support for merge queues isn't really that widespread in general; see also #6850

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants