-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR review "final report box" to show before merging #2579
Comments
This would be a good start for this feature |
Actually I'd like to see this more. Sometimes new users forget to mark "closes X" correctly so it'd be good to see "No issues will be closed when merging this PR" as well as "X Y and Z will be closed after merging. |
I need the warnings or even merge checks for Edit: Plus I think it would be more ideal if it wasn't a GitHub Action that needed to check for such commits. It doesn't feel right if an action checks this. Commits are metadata, it's not really the responsibility of a pipeline execution to deal with them. A PR pipeline typically executes some build and tests, and if the check for commits is implemented wrongly, it won't be a separate check but will fail the PR pipeline prematurely just because there's a fixup commit that will be squashed once everything is ready for merge. |
I mean, support for merge queues isn't really that widespread in general; see also #6850 |
When about to merge PRs:
we could show a final "report" box listing what's about to happen:
closes #11
keyword) or if none will be closed!squash
/!fixup
commits: Warn before merging a PR if it contains fixup or squash commits #2385What else could this include?
The text was updated successfully, but these errors were encountered: