Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter-comments-by-you not displayed any more on PR list page #2647

Closed
arnaudvalle opened this issue Dec 20, 2019 · 2 comments · Fixed by #2655
Closed

filter-comments-by-you not displayed any more on PR list page #2647

arnaudvalle opened this issue Dec 20, 2019 · 2 comments · Fixed by #2655
Labels

Comments

@arnaudvalle
Copy link
Contributor

arnaudvalle commented Dec 20, 2019

(Note: Initially reported as part of #2631 but they're two different issues)

Screenshot 2019-12-20 at 09 56 16

Example url: https://github.com/sindresorhus/refined-github/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc

  1. The link Everything commented by you added by the filter-comments-by-you is not showing up anymore.
  2. The icon of the button seems misaligned. (separate issue Filters selection box on issues page is blank #2651)
content.js:2997 TypeError: Cannot read property 'before' of null
    at filter_comments_by_you_init (content.js:5257)
    at features_run (content.js:2992)
    at content.js:3039
    at content.js:2949
@GF-Huang
Copy link

GF-Huang commented Jan 8, 2023

The problem arises again.

@refined-github refined-github locked and limited conversation to collaborators Jan 8, 2023
@fregante
Copy link
Member

fregante commented Jan 8, 2023

The feature works, the item has just been changed to "involved in"

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging a pull request may close this issue.

3 participants