Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTRL + Enter on approval window does not approve #2654

Closed
Jamesking56 opened this issue Dec 24, 2019 · 1 comment
Closed

CTRL + Enter on approval window does not approve #2654

Jamesking56 opened this issue Dec 24, 2019 · 1 comment
Labels

Comments

@Jamesking56
Copy link
Contributor

When approving a PR, entering in your approval comment and pressing CTRL+Enter does not click the 'Approve' button. It clicks the 'Comment' button.

image

As you can see in the screenshot, the 'Approve' button is primary so looks like it'll be the one clicking upon CTRL+Enter. But this is not the case.

@fregante
Copy link
Member

Correct, that’s the default action even without Refined GitHub (unless you change the checkbox). There are three choices, we can’t assume you mean “Approve” so we default to the least destructive one. If you change your mind you can then Approve the PR in a second “review”

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants