Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub added add-co-authored-by #2663

Closed
jetersen opened this issue Jan 3, 2020 · 2 comments · Fixed by #2665
Closed

GitHub added add-co-authored-by #2663

jetersen opened this issue Jan 3, 2020 · 2 comments · Fixed by #2665
Labels
change request

Comments

@jetersen
Copy link
Contributor

jetersen commented Jan 3, 2020

I think we can safely disable/remove the add-coauthored-by feature

This should be handled by the recent change, see the changelog:
https://github.blog/changelog/2019-12-19-improved-attribution-when-squashing-commits/
@fregante
Copy link
Member

fregante commented Jan 4, 2020

Can’t confirm at the moment but this would be great! PR welcome to remove it

@fregante fregante changed the title disable add-co-authored-by.tsx GitHub added add-co-authored-by Jan 4, 2020
@jetersen
Copy link
Contributor Author

jetersen commented Jan 4, 2020 •
edited

Tested and worked:
image

I specially disabled Refined GitHub and closed and opened a new the tab before clicking squash and merge.

https://github.com/casz/test-github-co-authored/pull/1

@jetersen jetersen mentioned this issue Jan 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
change request
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop add-co-authored-by feature
2 participants
@fregante @jetersen