Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mozilla Addons reviewer: "Please add a privacy policy" #2685

Closed
fregante opened this issue Jan 10, 2020 · 14 comments
Closed

Mozilla Addons reviewer: "Please add a privacy policy" #2685

fregante opened this issue Jan 10, 2020 · 14 comments
Labels
meta Related to Refined GitHub itself

Comments

@fregante
Copy link
Member

Just to keep you in the loop to help you understand why Firefox is stuck on version 19.12.9:

More information requested by Cse a day ago

Please add a privacy policy to this add-on that details which user data is being sent and to what services. The critical things to describe in the policy are how your extension collects, uses, stores, and shares or discloses information about people.If your add-on makes it apparent to websites that it is installed, this must also be mentioned. The policy should be about the extension only, not a copy of the website's privacy policy. It should also be the actual text, as opposed to a link to a privacy policy on a website. The privacy policy can be added in the add-on settings under “Manage Authors & License” on AMO.

My response:

Refined GitHub does not collect, use, store, nor share any data; we don't have servers. The extension only operates locally and on GitHub itself.

Help wanted to add a privacypolicy file in case they make this a hard requirement.

@fregante fregante added help wanted firefox Related to Firefox only Please! ♥︎ Particularly useful features that everyone would love! labels Jan 10, 2020
@fregante fregante pinned this issue Jan 10, 2020
@fregante
Copy link
Member Author

Latest:

There should be a privacy policy that states what kind of data is sent to github servers

Help.

@jerone
Copy link
Contributor

jerone commented Jan 10, 2020

I was just about to open an issue about the missing Firefox version.


Some info I found on the internet about privacy policies for extensions:

None of the other GitHub related extensions have an Privacy Policy.

English is not my native language, so I'm not the best person to write a policy.

@fregante
Copy link
Member Author

fregante commented Jan 10, 2020

Perhaps:

This extension communicates with GitHub to display additional data related to files, repositories and users. GitHub will receive the same unmodified cookies from GitHub.com or your Personal Access Token, if you provide one. Some actions like "Revert Changes to File" will use the GitHub API to create a commit only when initiated by the user. The authentication is done directly between the extension and GitHub, no third party server is involved. There's no advertising and no analytics.

@sindresorhus can you add it here? It's read-only for me https://addons.mozilla.org/en-US/developers/addon/refined-github-/ownership

@fregante
Copy link
Member Author

@sindresorhus also Chrome is stuck on 4 versions ago and the 20.1.6 publish command returned "OK". Does the Chrome Store say anything about it?

@sindresorhus
Copy link
Member

can you add it here? It's read-only for me addons.mozilla.org/en-US/developers/addon/refined-github-/ownership

✅ Very well written.

@sindresorhus
Copy link
Member

also Chrome is stuck on 4 versions ago and the 20.1.6 publish command returned "OK". Does the Chrome Store say anything about it?

Screenshot 2020-01-11 at 18 21 33

@fregante
Copy link
Member Author

Wow... worse waiting times than AMO.

Let's see if the policy is enough. Could still be rejected for being too vague

@jerone
Copy link
Contributor

jerone commented Jan 13, 2020

It looks like the Firefox version was accepted; I got an update to 20.1.6 today. 🦊

@fregante
Copy link
Member Author

Hallelujah!

@fregante fregante unpinned this issue Jan 13, 2020
@fregante
Copy link
Member Author

fregante commented Feb 14, 2020

@sindresorhus also Chrome

"message": "Publish condition not met: To publish your item, you must provide mandatory privacy information. This can be done in the new Developer Dashboard."

@fregante fregante reopened this Feb 14, 2020
@fregante fregante removed Please! ♥︎ Particularly useful features that everyone would love! help wanted firefox Related to Firefox only labels Feb 14, 2020
@sindresorhus
Copy link
Member

Screenshot 2020-02-14 at 17 30 45

Why do we need the activeTab permission (specifically)?

@fregante
Copy link
Member Author

fregante commented Feb 14, 2020

To enable GH on Enterprise https://github.com/fregante/webext-domain-permission-toggle

activeTab lets us read the URL of the tab where the user clicks "enable"

@sindresorhus
Copy link
Member

Ok, submitted. They warned that it could take up to several weeks to review...

@sindresorhus
Copy link
Member

While we wait for Google, maybe there's something we can improve with the privacy form I filled out?


Single Purpose Description
The extension adds power-user features to GitHub.com.

activeTab
We need this to be able to enable the extension on GitHub Enterprise. activeTab lets us read the URL of the tab where the user clicks "enable". https://github.com/fregante/webext-domain-permission-toggle

Host Permission
We need access to https://github.com/* to add the features and access to https://api.github.com/* to fetch required data for some of the features we add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Related to Refined GitHub itself
Development

No branches or pull requests

3 participants