Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Approve and Merge" button on Comments and/or Files changed page #2702

Closed
ypresto opened this issue Jan 14, 2020 · 2 comments
Closed

"Approve and Merge" button on Comments and/or Files changed page #2702

ypresto opened this issue Jan 14, 2020 · 2 comments

Comments

@ypresto
Copy link

ypresto commented Jan 14, 2020

I frequently write "LGTM!" comment and push Approve button on Files changed page of PR, then redirected to Comments page and then push Merge button.
Because that redirection is quite slow, it'd be better if we have Approve and Merge button on Files changed page.

Also, Sometimes I write additional review comments on Comments page before approving. So it's nice to have that button on Comments page too.

@fregante fregante marked this as a duplicate of #2700 Jan 14, 2020
@fregante fregante marked this as not a duplicate of #2700 Jan 14, 2020
@fregante fregante reopened this Jan 14, 2020
@fregante
Copy link
Member

This request sounds like the opposite of #883

That request was about "Approving from the Conversation tab" and this one is about "Merge from the Files tab"

Neither one is particularly easy to implement, but this is harder: merging a PR means also writing the commit title and message, so to "Approve and merge" we have to ALSO show those two fields inside the review box.

Can't do. It would be too much.


Is your repo set up to require approvals before merging? Because if not, you don't need to Approve and merge: just leave a regular comment and merge from the Conversation tab.

@ypresto
Copy link
Author

ypresto commented Jan 16, 2020

merging a PR means also writing the commit title and message,

Off-topic: Maybe I need 1-Click® merge button which uses default title and message; I always don't change them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants