You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I frequently write "LGTM!" comment and push Approve button on Files changed page of PR, then redirected to Comments page and then push Merge button.
Because that redirection is quite slow, it'd be better if we have Approve and Merge button on Files changed page.
Also, Sometimes I write additional review comments on Comments page before approving. So it's nice to have that button on Comments page too.
The text was updated successfully, but these errors were encountered:
That request was about "Approving from the Conversation tab" and this one is about "Merge from the Files tab"
Neither one is particularly easy to implement, but this is harder: merging a PR means also writing the commit title and message, so to "Approve and merge" we have to ALSO show those two fields inside the review box.
Can't do. It would be too much.
Is your repo set up to require approvals before merging? Because if not, you don't need to Approve and merge: just leave a regular comment and merge from the Conversation tab.
I frequently write "LGTM!" comment and push Approve button on
Files changed
page of PR, then redirected toComments
page and then push Merge button.Because that redirection is quite slow, it'd be better if we have
Approve and Merge
button onFiles changed
page.Also, Sometimes I write additional review comments on
Comments
page before approving. So it's nice to have that button onComments
page too.The text was updated successfully, but these errors were encountered: