Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make update-pr-from-base-branch's button smaller #2723

Closed
2 tasks
fregante opened this issue Jan 21, 2020 · 1 comment · Fixed by #3154
Closed
2 tasks

Make update-pr-from-base-branch's button smaller #2723

fregante opened this issue Jan 21, 2020 · 1 comment · Fixed by #3154
Labels
help wanted small Issues that new contributors can pick up under discussion

Comments

@fregante
Copy link
Member

Currently the "Update branch" is rather large and it looks like an action that should be taken. It's not really something the user should do that often, so we should probably de-emphasize it.

This is an alternative, it just replaces .btn with .btn-link:

Also:

  • it should probably use a window.prompt() window to ask for confirmation
  • it could have an "info" icon with a link to "Update Branch" button for stale branches #1236 or any other post with a clearer explanation of when this action may be useful
@fregante fregante added help wanted under discussion small Issues that new contributors can pick up labels Jan 21, 2020
@fregante
Copy link
Member Author

Keep in mind: drafts have a different copy.

Screen Shot 2020-01-22 at 12 08 02

Maybe it can be added as:

Draft pull requests cannot be merged. You can update the base branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted small Issues that new contributors can pick up under discussion
Development

Successfully merging a pull request may close this issue.

2 participants
@fregante and others