-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't auto turn on new features #2743
Comments
Why? |
Most recent one was updating pr title, which updates PR title when they are merged, which I didn't expect. What we can do is show a page when the extension updates with new features, so user can choose which features they want to turn on. |
I tried looking back that feature was added waaaaay back https://github.com/sindresorhus/refined-github/blob/d747ed5c2f550435a908150b41f4bb3b6cb53b50/src/features/fix-squash-and-merge-title.js it goes back even farther... Regarding new features, I strongly disagree. When ever you update an app do you expect them to have all new features disabled? |
I agree that enhancements are expected to be on by default and they should be. But things like deleting branches, updating pr titles, etc should at least be informed to the user. I am not talking about squash and merge by the way, it's sync-pr-commit-title https://github.com/sindresorhus/refined-github/blob/master/source/features/sync-pr-commit-title.tsx |
@iamsolankiamit that function was just updated to do more. Lets not get petty.
Looks like these are the only things you have an issue with. |
Anything that might affect other contributors, should be informed to user. Visual and other enhancements that only affect the user who installed are fine imo. |
Yea, that could help. |
Duplicate of #2664 I’ll copy it here:
If you don’t want new features, disable the updates and only update when needed. Also #2668 can help you see which features are new |
We do have a notice for the title change and it’s right by the title. It also allows the user to cancel it in-place. Regarding the branches deletion, we already discussed this when the feature was implemented but we consider it non-destructive because:
|
Whenever there is an update, especially related to PRs, branches, etc please don't enable them by default.
The text was updated successfully, but these errors were encountered: