Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

highlight-collaborators-and-own-discussions not working on milestone issues list #2792

Closed
jerone opened this issue Feb 16, 2020 · 1 comment · Fixed by #2793
Closed

highlight-collaborators-and-own-discussions not working on milestone issues list #2792

jerone opened this issue Feb 16, 2020 · 1 comment · Fixed by #2793
Labels
bug

Comments

@jerone
Copy link
Contributor

jerone commented Feb 16, 2020

Example page: https://github.com/ForkIssues/TrackerWin/milestones/1.45

highlight-collaborators-and-own-discussions are not highlighted there.

Maybe more features are not active on that list.
@jerone jerone added the bug label Feb 16, 2020
@dertieran
Copy link
Contributor

dertieran commented Feb 16, 2020 •
edited

I guess that's just because /milestones/xyz isn't supported by isRepoDiscussionList.
https://github.com/sindresorhus/refined-github/blob/244052c16032f93623b968e1550372bd71231c84/source/libs/page-detect.ts#L257-L260

@dertieran dertieran mentioned this issue Feb 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Apply features to Milestone issue lists dertieran/refined-github
2 participants
@jerone @dertieran