Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few of problems, just after waking up #2797

Closed
tunnckoCore opened this issue Feb 18, 2020 · 4 comments
Closed

A few of problems, just after waking up #2797

tunnckoCore opened this issue Feb 18, 2020 · 4 comments
Labels

Comments

@tunnckoCore
Copy link

tunnckoCore commented Feb 18, 2020

  1. Sidebar is not sticky #2770
  2. The "More" dropdown is always like when clicked (in every page). I think we had similar issue before few? Hm. I don't remember how we fixed it.
  3. The extension "Options" is doing something strange, constantly moving/resizing - can't show that.. Maybe from few pictures below you can see it has different size. It stops when you, for example, somehow successfully click on some of the inputs and "save" the options with "Enter".

2020-02-18-124209_1280x1024_scrot_001
2020-02-18-124209_1280x1024_scrot_000

  1. Reinstalled the extension
  2. errors in console (when in an Issue)
 ❌ make-discussion-sidebar-sticky
content.js:1896 TypeError: Cannot read property 'offsetHeight' of null
    at updateStickiness (content.js:3269)
    at make_discussion_sidebar_sticky_init (content.js:3276)
    at features_run (content.js:1891)
    at content.js:1944
    at onAjaxedPagesRaw (content.js:1843)
features_run @ content.js:1896
 
❌ link-to-file-in-file-history
content.js:1896 TypeError: Cannot read property 'children' of null
    at cleanSection (content.js:5986)
    at clean (content.js:6024)
    at clean_sidebar_init (content.js:6039)
    at features_run (content.js:1891)
    at content.js:1944
    at content.js:1848
    at onAjaxedPagesRaw (content.js:1843)
  1. more errors in Repo pages

2020-02-18-125917_1280x1024_scrot

  1. What permissions the token need? Mine has gist, notifications, repo, user, workflow and it's new.
  2. The "hide marketplace" wraps the anchor a tag with a div that makes too much space between the "Issues" and "Trending"? You can see it from above screenshot.
<div class="mr-0 mr-lg-3 py-2 py-lg-0 border-top border-lg-top-0 border-white-fade-15">
      <a class="js-selected-navigation-item Header-link" data-ga-click="Header, click, Nav menu - item:marketplace context:user" data-octo-click="marketplace_click" data-octo-dimensions="location:nav_bar" data-selected-links=" /marketplace" href="/marketplace">
        Marketplace
</a>      

    </div>
@fregante
Copy link
Member

fregante commented Feb 18, 2020

I don't know how but you're using an extremely old version of Refined GitHub.

make-discussion-sidebar-sticky hasn't existed since August 2019 because it was renamed https://github.com/sindresorhus/refined-github/commits/master/source/features/sticky-discussion-sidebar.tsx

@tunnckoCore
Copy link
Author

tunnckoCore commented Feb 18, 2020

I don't know either. As I said, I just reinstalled it from the chrome store, and it's 20.2.14.922 which seems to be right.

2020-02-18-133434_1280x1024_scrot

In anyway, there is ton of other stuff in this issue other than the sticky thing.

And I'm continuing:

  1. Disabling more-dropdown, removes the releases tab too (while releases-tab is enabled). The problem is that releases-tab throws error
❌ releases-tab
content.js:1896 TypeError: Cannot read property 'before' of null
    at releases_tab_init (content.js:2546)
    at async features_run (content.js:1891)
features_run @ content.js:1896
  1. disabling deprioritize-marketplace-link seems to not work, it still hides it. The interesting thing is it neither shows as ✔️ , nor as skipped.
  2. "repo age" doesn't appear too.
  3. hide-navigation-hover-highlight is shown as ✔️ , but doesn't work either, menus/nav has hover.
  4. latest-tag-button is nor ✔️ , nor skipped, should be disabled.

Seems like there is some problem with disabling and other stuff.

@fregante
Copy link
Member

fregante commented Feb 18, 2020

This is due to #2796

Sorry about that, try avoiding changing any settings or else they'll be lost

@tunnckoCore
Copy link
Author

Ah yea, thanks. I'll just leave it and try later or tomorrow :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants