Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugs-tab doesn't work with uppercase Bugs tag #2816

Closed
staabm opened this issue Feb 20, 2020 · 23 comments
Closed

bugs-tab doesn't work with uppercase Bugs tag #2816

staabm opened this issue Feb 20, 2020 · 23 comments
Labels

Comments

@staabm
Copy link

staabm commented Feb 20, 2020

I am wondering why I don't get a "Bugs" tab on https://github.com/redaxo/redaxo but i can see it on other reposes with the same browser?

using FF 75.0a1 (2020-02-19) (64-bit) and refined github 20.2.19

@staabm staabm added the bug label Feb 20, 2020
@fregante
Copy link
Member

Because label:bug doesn’t match Bug

@fregante fregante removed the bug label Feb 20, 2020
@staabm
Copy link
Author

staabm commented Feb 20, 2020

ok, so we should change the label form "Bug" to "bug"?

or should refined github be case-insensitive in this case?

@fregante
Copy link
Member

It’s not Refined GitHub but GitHub themselves. Their tags are case sensitive

@yakov116
Copy link
Member

@fregante https://github.com/redaxo/redaxo/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+label%3Abug
will bring up the bugs tab (the search is not case sensitive)

@fregante
Copy link
Member

GitHub search may not be, but the labels API is. Maybe we need to change it to use the search API instead

@jdreesen
Copy link

I think it makes sense to be case-insensitive here.

@luwes

This comment has been minimized.

@luwes

This comment has been minimized.

@fregante

This comment has been minimized.

@fregante

This comment has been minimized.

@luwes

This comment has been minimized.

@luwes

This comment has been minimized.

@luwes

This comment has been minimized.

@fregante fregante changed the title Missing 'Bugs' tab bugs-tab doesn't work with uppercase Bugs tag Mar 18, 2020
@fregante fregante added the bug label Mar 18, 2020
@staabm
Copy link
Author

staabm commented Mar 23, 2020

the initially reported repo does still not show the "Bugs" tab for me even when using the latest refined-github release:

https://github.com/redaxo/redaxo

grafik

@staabm
Copy link
Author

staabm commented Apr 8, 2020

I dont have the permission to re-open this issue, but since the bug still exists I guess we should @fregante ..?

(see comment above for a repro)

@fregante
Copy link
Member

fregante commented Apr 8, 2020

It works both in Firefox

Screen Shot 2020-04-08 at 13 07 32

And Chrome

chrome

Are you using the latest version? Any errors in the console?

@staabm
Copy link
Author

staabm commented Apr 8, 2020

I am on 20.4.5 and testing in firefox 77.0a1.

the feature works for me in other repositories.

I get a error in the browser-console, not sure this is related
grafik

but works on the refined github repo with the very same Firefox

grafik

@staabm
Copy link
Author

staabm commented Apr 8, 2020

I also can reproduce the problem in Chrome 84 with refined github 20.4.1

grafik

in this very same chrome instance the "Bugs" tab appears when browsing e.g. the refined github repo itself:

grafik

@yakov116
Copy link
Member

yakov116 commented Apr 8, 2020

@staabm can you try to clear the cashe?

@staabm
Copy link
Author

staabm commented Apr 8, 2020

can you try to clear the cashe?

which cache? how to clear it?

@yakov116
Copy link
Member

yakov116 commented Apr 8, 2020

open the extension options all the way on the bottom

image

@fregante
Copy link
Member

fregante commented Apr 8, 2020

  1. Open https://github.com/redaxo/redaxo in Chrome
  2. Clear the cache
  3. Open the dev tools
  4. Refresh the page
  5. Search "graphql"
  6. Find the query that looks like this

One of the queries should be (in the Headers tab):

{
	search(type: ISSUE, query: "label:bug is:open is:issue repo:redaxo/redaxo") {
		issueCount
	}
}

@staabm
Copy link
Author

staabm commented Apr 8, 2020

thx for the hints guys!

clearing the cache did it. I can see the tab now in Firefox and in Chrome.

I guess there is some cache eviction problem going on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

5 participants