New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dim-merge-commits
feature
#2827
Comments
So bringing back #1988? Sounds good! |
@sindresorhus we only dropped it, since github removed the class to be able to check that it was there. |
@sindresorhus exactly! Except now it requires an API request for every |
@fregante wouldn't it be the same as add-tags-to-comits I started looking into the code and then I realized your going to want to save each commit to storage. Just curious are we not already that we can use it for both things? |
That feature is too complex and I don’t want a copy of it. If anything we should drop/simplify the caching from it. |
@fregante do you have any idea how we can figure out if its a merge commit. I tried all ways I cant figure out a normal way. |
I think only merge commits have 2 parent commits |
@fregante Im working on it |
This would solve the "noise" concern mentioned in #2768
It would have to use a combined GraphQL query to determine which commits on the current page are merge commits, and then just apply
opacity: 0.6
on their whole line. Or something like that."Combined GraphQL query" example: https://github.com/sindresorhus/refined-github/pull/2795/files#diff-04c19a6c246911e079b45f999eab501cR14-R22
Test URL
https://github.com/babel/babel/commits/master?after=ddd40bf5c7ad8565fc990f26142f85613958a329+104
Originally posted by @fregante in #2768 (comment)
The text was updated successfully, but these errors were encountered: