Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension seems to hide assignees menu from issues and PRs #2836

Closed
akmadian opened this issue Feb 26, 2020 · 10 comments
Closed

Extension seems to hide assignees menu from issues and PRs #2836

akmadian opened this issue Feb 26, 2020 · 10 comments
Labels

Comments

@akmadian
Copy link

Refined GitHub seems to be removing or otherwise hiding the assignees menu from issues and PRs. I tried disabling and re-enabling the extension to test it, and it always disapears when enabled, and reappears when disabled.

Oddly, the assignees menu shows, and I can interact with it when there is already someone assigned, but does not show when there is no one assigned.

No assignees (Refined GitHub enabled):
no-assignees

With Assignees (Refined GitHub disabled):
w-assignees

The same thing happens when viewing a PR.

@akmadian akmadian added the bug label Feb 26, 2020
@akmadian
Copy link
Author

Forgot to add version info:
Browser: Firefox Dev Edition 74.0
OS: Win 10 Pro 1809
Extension: 20.2.19

@fregante
Copy link
Member

Empty sections are completely removed if RGH doesn’t think you can edit them. Here either this detection is broke for Assignees, or some other selector needs to be updated

@akmadian
Copy link
Author

I'm not a full member of the Creative Commons org, I'm a collaborator, so maybe that's affecting it? Is there a toggle for this in settings? I love RGH, but I can't use it if there's no way to turn this off :/

@fregante
Copy link
Member

This is the clean-sidebar feature you can disable temporarily in the options.

The detection happens in the DOM: if there’s a “settings” icon, then you can edit it, so the section should not be removed.

@akmadian
Copy link
Author

Yep, just found it and was about to comment with the name of the setting. It does have a gear icon on it, so I'm not sure what the deal is.

Do you consider this to be a proper bug that needs fixing? If so, I could investigate further if I can find the time.

@fregante
Copy link
Member

fregante commented Feb 28, 2020

Do you consider this to be a proper bug that needs fixing?

Yep, it's a bug, but I can't reproduce it. This is what it looks like for me:

If you look into the issue, maybe you can find out why it's not working correctly there.

Extension errors don't appear in the regular console, so use the Browser Console

@akmadian
Copy link
Author

akmadian commented Feb 28, 2020

Sounds good, will investigate soon :) It may have to do with my permissions for the CC org as I'm not a member with full perms, but I help maintain a couple repos (the repo in screenshots is one of them).

@yakov116
Copy link
Member

yakov116 commented Apr 5, 2020

@fregante wasn't this fixed?

@fregante
Copy link
Member

fregante commented Apr 5, 2020

@yakov116 thanks! I forgot to close it in #2916

@fregante fregante closed this as completed Apr 5, 2020
@Visne
Copy link

Visne commented Feb 19, 2021

I'm still having this issue Firefox 85.0.2 (64-bit), addon version 21.2.9.
When there is actually someone assigned, it's visible however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

4 participants