Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github image scaling on comment stream #2935

Closed
stdedos opened this issue Mar 25, 2020 · 3 comments
Closed

Github image scaling on comment stream #2935

stdedos opened this issue Mar 25, 2020 · 3 comments

Comments

@stdedos
Copy link

stdedos commented Mar 25, 2020

Example issue: sublimehq/Packages#1781 (comment)

The scaling done on the images in issue comments is annoying. Basically, if the image width is bigger than the issue box, then you must open the image to read it on a separate tab.

For me (i.e. my JS level), it is very easy to solve, and I already love it:

image

i.e. disable max-width: 100%; on the element and the class


However, for Refined Github's level:

  • Add a horizontal scrolling bar; the "normal" one or one of those cute round "invisible" gray ones, and/or
  • Add an "expand" button that would widen the issues a little bit (there is more space in WQHD monitors) / pop up the image
@yakov116
Copy link
Member

yakov116 commented Mar 25, 2020

It looks fine by me?? misunderstood.

Disagree. nmv

@fregante
Copy link
Member

fregante commented Mar 25, 2020

I see your point, ideally clicking the image would show it full size.

Then clicking it again would reset it.

You're lucky! Clicking the image already does show it as big as possible, in a new tab, automatically, thanks to Markdown's automatic image linking.

Pros:

  • 1 click to open it
  • 1 click to close it (or keyboard shortcut: ctrl+w/cmd+w)
  • fits your whole window without scrollbars
  • lets you easily zoom in and scroll
  • we don't have to write any code for it 🎉

The alternative would be to show it in a lightbox... but what's the advantage? Too much work just to avoid opening a new tab.

... at least as far as Refined GitHub is concerned.

Maybe GitHub will accept your feature if you ask them.

@FichteFoll
Copy link

For other purposes, I suggest using a browser addon like Imagus that provides a dynamic popup for all images and even special handlers for some sites.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants