Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect first tab’s size in .md files’s diffs #2970

Closed
fregante opened this issue Apr 3, 2020 · 4 comments
Closed

Incorrect first tab’s size in .md files’s diffs #2970

fregante opened this issue Apr 3, 2020 · 4 comments
Assignees
@fregante
Labels
bug help wanted Please! ♥︎ Particularly useful features that everyone would love! small Issues that new contributors can pick up

Comments

@fregante
Copy link
Member

fregante commented Apr 3, 2020

  1. Visit https://github.com/sindresorhus/refined-github/pull/2925/files#diff-cc4aac3e9be04e0413c9520f223b493c
  2. The tab is 1-space wide instead of 4

bug

For some reason this doesn't happen to other filetypes, they're displayed with the right size:

no-bug
@fregante fregante added bug help wanted Please! ♥︎ Particularly useful features that everyone would love! labels Apr 3, 2020
@fregante fregante changed the title show-whitespace changes display of first tab in .md files’s diffs Incorrect first tab’s size in .md files’s diffs Apr 3, 2020
@fregante
Copy link
Member Author

fregante commented Apr 3, 2020

I double-checked and this doesn't seem to be due to show-whitespace

@notlmn
Copy link
Contributor

notlmn commented Apr 4, 2020

Can confirm happening on Firefox version with 20.4.1, but not on Chrome version which is still on 20.3.26.

@yakov116
Copy link
Member

yakov116 commented Apr 5, 2020

Not seeing it at all on master in chrome

@yakov116
Copy link
Member

Its remove-diff-signs and only in firefox

@fregante fregante added the small Issues that new contributors can pick up label Apr 14, 2020
@fregante fregante self-assigned this Apr 14, 2020
@fregante fregante mentioned this issue May 2, 2020
Closed
@notlmn notlmn mentioned this issue May 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fregante fregante

Labels
bug help wanted Please! ♥︎ Particularly useful features that everyone would love! small Issues that new contributors can pick up
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fregante @yakov116 @notlmn