Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project tabs don't fit on their line #3102

Closed
yallie opened this issue May 18, 2020 · 5 comments · Fixed by #3106
Closed

Project tabs don't fit on their line #3102

yallie opened this issue May 18, 2020 · 5 comments · Fixed by #3106
Labels
bug help wanted small Issues that new contributors can pick up

Comments

@yallie
Copy link

yallie commented May 18, 2020

Page url: https://github.com/sindresorhus/refined-github

Screenshot with refined-github enabled:
image

Screenshot with refined-github disabled:
image

@yallie yallie added the bug label May 18, 2020
@notlmn
Copy link
Contributor

notlmn commented May 18, 2020

That's ZenHub extension flexing out the .repo-nav element, causing elements we add there to flow down.

image

This is more of a compatibility issue between ZenHub and this extension than a bug from this issue.


Also @fregante WDYT about adding "more dropdown" and "releases tab" inside the ul as opposed to beside it?

@yallie
Copy link
Author

yallie commented May 18, 2020

That's ZenHub extension flexing out the .repo-nav element, causing elements we add there to flow down.

Oh, I thought I've disabled all github-related extensions before posting this issue.
I forgot about ZenHub, indeed. Thank you!

@fregante
Copy link
Member

Also @fregante WDYT about adding "more dropdown" and "releases tab" inside the ul as opposed to beside it?

Sounds good, GitHub must have changed the DOM.

Also I suggest reporting this to ZenHub. Why are they setting flex on the whole element? Doesn't look necessary.

@fregante fregante added small Issues that new contributors can pick up help wanted labels May 18, 2020
@notlmn
Copy link
Contributor

notlmn commented May 18, 2020

That's ZenHub extension flexing out the .repo-nav element, causing elements we add there to flow down.

Oh, I thought I've disabled all github-related extensions before posting this issue.
I forgot about ZenHub, indeed. Thank you!

That did help us find this issue where the elements we add now appear after the settings tab. Sending in a fix for this.

image

@fregante
Copy link
Member

This also explains why I’ve been seeing the Releases being added AFTER the settings tab. That’s not right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug help wanted small Issues that new contributors can pick up
Development

Successfully merging a pull request may close this issue.

3 participants