Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clear-pr-merge-commit-message should preserve commit message if only a single commit is squashed #3140

Closed
marcphilipp opened this issue May 26, 2020 · 1 comment · Fixed by #3141
Closed

clear-pr-merge-commit-message should preserve commit message if only a single commit is squashed #3140

marcphilipp opened this issue May 26, 2020 · 1 comment · Fixed by #3141
Assignees
@fregante
Labels
change request help wanted small Issues that new contributors can pick up

Comments

@marcphilipp
Copy link

We use "Squash & Merge" even for PRs with a single commit, because we require commits to be signed and GitHub does not sign commits when doing "Rebase & Merge". Thus, it would be great, if the commit message box would be pre-filled with the commit message of the first and only commit on the PR branch.
@fregante fregante added change request small Issues that new contributors can pick up help wanted and removed bug labels May 26, 2020
@fregante fregante self-assigned this May 26, 2020
@fregante fregante mentioned this issue May 26, 2020
Merged
@marcphilipp
Copy link
Author

Awesome, thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fregante fregante

Labels
change request help wanted small Issues that new contributors can pick up
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Exclude 1-commit PRs from clear-pr-merge-commit-message refined-github/refined-github
2 participants
@marcphilipp @fregante