Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the wording of revert-file commit #3161

Closed
yakov116 opened this issue Jun 1, 2020 · 6 comments · Fixed by #3238
Closed

Change the wording of revert-file commit #3161

yakov116 opened this issue Jun 1, 2020 · 6 comments · Fixed by #3238

Comments

@yakov116
Copy link
Member

yakov116 commented Jun 1, 2020

Currently the wording is Revert {fileName}. Revert follow-file-renames.tsx

I would like it to say Revert changes made to {filename}

@yakov116 yakov116 changed the title Change wording of revert-file Change the wording of revert-file commit Jun 1, 2020
@fregante
Copy link
Member

fregante commented Jun 1, 2020

I just found out that there’s a command called git restore and we should probably match its wording

@yakov116
Copy link
Member Author

yakov116 commented Jun 1, 2020

I just found out that there’s a command called git restore and we should probably match its wording

I tried it out git restore is just a git-reset on a file and does not commit anything

@fregante
Copy link
Member

fregante commented Jun 1, 2020

Indeed. However given that restore is the right term for the operation, the Menu item should probably say Restore file and the commit Restore {filename}.

I think "changes" is implied when talking about git.

@yakov116
Copy link
Member Author

yakov116 commented Jun 4, 2020

Should the feature be renamed to Restore file?

@yakov116
Copy link
Member Author

yakov116 commented Jun 4, 2020

@fregante ?

@yakov116
Copy link
Member Author

Bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants