Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keyboard-navigation issues #3319

Closed
fregante opened this issue Jul 6, 2020 · 0 comments · Fixed by #3377
Closed

keyboard-navigation issues #3319

fregante opened this issue Jul 6, 2020 · 0 comments · Fixed by #3377
Labels
bug help wanted

Comments

@fregante
Copy link
Member

fregante commented Jul 6, 2020 •
edited

Hidden conversations in Files tabs are "focused"

  1. Visit https://github.com/sindresorhus/refined-github/pull/3242/files
  2. Press the i key
  3. Press j 3 times

You'll see that the focus sometimes is lost because it's focusing the hidden comments

PR reviews are skipped

Messageless reviews don't have a focus ring so I asked to exclude reviews, but I didn't realize that this also excludes reviews with a message

Is it possible to focus the latter without focusing the former?

Others

I might have forgotten other issues. Please write them below
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix keyboard-navigation issues dertieran/refined-github
1 participant
@fregante