New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically disable some features on large PRs #3567
Comments
Is #1783 large enough? |
Not for me, it's buttery smooth on my 2013 laptop. We need the users who report slowdowns to post their slow URLs. |
https://github.com/RudiDeVos/UltraVNC/commit/4fbe8afcacc9cf181413402c1441d17ea79fdf25 With RH can barley get past the first file without chopping up. This is on a solid desktop computer.
|
That gif was recorded inside |
@fregante I should have recorded it... maybe next week |
What's your CPU? Also try it in |
It does lag a bit, but after a few seconds it's totally fine. I guess it's because GitHub folded most of the files so RGH doesn't really need to process a huge amount of lines. We probably need a PR that consists of lots of files that aren't long enough to be folded by GitHub. |
@fregante maybe it was not a fair test. I did it on my work computer (in middle of work shhh). I did have about 45 (if not more) other chrome tabs open and work items too. I will test again next week with only that one page open and only RH enabled. When I posted the link I incorrectly assumed that you would see the same results so I did not bother recording. |
Closing. New issues can be opened with specific "feature + large PR" combination. |
A few times people reported some features being slow on large PRs.
I wonder if, like GitHub does for large comparison, we could disable some/all features on large PRs and show a notice like "Some RG features were disabled because this page is gargantuan."
However, this need your help. Please post links to such large PRs. No real-life examples, no chances of this being fixed.
The text was updated successfully, but these errors were encountered: