Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Automatically delete the branch right after merging a PR, if possible" should be optional #3636

Closed
jimklimov opened this issue Oct 9, 2020 · 2 comments

Comments

@jimklimov
Copy link

After installing the browser plugin, the GitHub Web-GUI no longer offers a checkbox to delete original branches of PRs but just kills them off (and then I can "Undo" the action). For many workflows it makes sense, however for some of ours it does not. Can this feature be changed to showing the checkbox like original GitHub does, just perhaps pre-ticking it to keep Refined GitHub's default behavior expected by its long-time users?

I got a bit lost in the long list of options I can configure for the extension in my browser, so not sure if there is a setting for this behavior already, or if the branch deletion is currently hardcoded.

Thanks a lot for the nifty extension :)

@jimklimov
Copy link
Author

Upon some more poring into the extension options, there is a "pr-branch-auto-delete" toggle so at least that is configurable (at least a reference from README about the feature is an easy fix that would help those in my shoes).

jimklimov added a commit to jimklimov/refined-github that referenced this issue Oct 9, 2020
Clarify the existence of "pr-branch-auto-delete" option to alleviate issue refined-github#3636
@fregante
Copy link
Member

fregante commented Oct 9, 2020

It’s optional and it is in the (admittedly very long) readme:

Automatically deletes the branch right after merging a PR, if possible.

In both the readme and the settings page, you can filter/search “delete” to find it easily.

If your workflow expects long-lived branches, then they should be protected in the native repo settings itself.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

2 participants