Display confirmation box when closing an issue with a comment

[Richienb]

Useful to avoid accidentally closing issues.

Should be applied for all issue pages: https://github.com/*/*/issues/*

Should be triggered when clicking this button:

[yakov116]

Don't we already put the close button on the other side to avoid this issue?

[fregante]

Should be triggered when clicking this button:

I did this accidentally a few times, but I don't know if I'd find the confirmation less annoying than just reopening the issue 🤔

Don't we already put the close button on the other side to avoid this issue?

Yes: https://github.com/sindresorhus/refined-github/blob/382b398cbaccbb5a3f7135cf873f1302daf5901e/source/features/safer-destructive-actions.css

[Richienb]

Perhaps, instead, there should be a 2-second countdown that allows you to immediately cancel the action.

[fregante]

Given the non-destructiveness of the action I don't think it's worth messing with that. That button already has enough logic behind it (and more is coming with #3881)

[fregante]

As annoying as it is (honestly, just a little), I think having to confirm your action even when you want to close it actually makes it worse.

Now:

• intentional: 1 click
• unintentional: 2 clicks

With a confirmation

• intentional: 2 clicks
• unintentional: 2 clicks

🤷‍♂️

[sgreene570]

In some cases, closing an issue accidentally can have unintended consequences, such as triggering (the start or end of) different github actions. It can also lead to confusion among PR reviewers, especially if GH events are pushed to some external source (slack channels, etc).

@fregante would it be possible to re-open this issue?