Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linkify quote replies #4024

Closed
make-github-pseudonymous-again opened this issue Feb 26, 2021 · 8 comments
Closed

Linkify quote replies #4024

make-github-pseudonymous-again opened this issue Feb 26, 2021 · 8 comments
Labels
enhancement impossible Features requests that are impossible or impractical to implement under discussion

Comments

@make-github-pseudonymous-again
Copy link

When an issue discussion includes more than two people it makes sense to add a link to the quoted comment. I do not think automatically adding an @-mention makes sense since you may not want this by default and it is easily added by hand.
Full URL where the feature should appear: https://togithub.com/sindresorhus/refined-github/issues/4024

@fregante
Copy link
Member

So do you want existing conversations to be linkified somehow or that a link should be added before leaving a comment?

@make-github-pseudonymous-again
Copy link
Author

A link should be hard-catenated to the quote.

@make-github-pseudonymous-again
Copy link
Author

Unless this is against some existing standard...

@fregante
Copy link
Member

So you mean you want your own comments to include a link for everyone else to see?

@make-github-pseudonymous-again
Copy link
Author

Yes. Maybe useless if it does not become standard GitHub behavior.

@fregante
Copy link
Member

fregante commented Mar 1, 2021

@fregante
Copy link
Member

fregante commented Mar 1, 2021

I'd find it useful as well, but adding this feature would mean at least one of these:

A. Hacking the native R shortcut and "Quote Reply" features to add a link
B. Recreating the whole "quote text" feature
C. Adding a button

They're likely impossible, heavy (due to a DOM-to-Markdown converter), inexact (i.e. different from the native converter), error-prone (we had the converter before, it required several fixes) and visually noisy.

I think the script above will have to do. It does what it does by using B and C.


Other than that, you could just right-click the comment’s time, copy its URL and paste it after quoting it.

@fregante fregante closed this as completed Mar 1, 2021
@fregante fregante added the impossible Features requests that are impossible or impractical to implement label Mar 1, 2021
@make-github-pseudonymous-again
Copy link
Author

Yep. That makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement impossible Features requests that are impossible or impractical to implement under discussion
Development

No branches or pull requests

2 participants