Unhide new suggestions icon #1587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, do we still want to hide the @ and # buttons? That CSS rule needs updated more if so, or it can just be removed entirely. I can do that in this PR too. |
|
Let's get this in and we can open a separate issue on reworking all CSS selectors around that toolbar properly. |
hkdobrev
approved these changes
Oct 16, 2018
etlasky
approved these changes
Oct 16, 2018
|
Yes we still want to hide those. They make no sense as buttons: just type @ and # Also doesn’t this PR unhide something else we don’t want to show? |
|
I think the rest was unhidden for some reason before that. Let's discuss that whole toolbar and the implementation. This was just a quick fix for new GitHub feature. |
sindresorhus
pushed a commit
that referenced
this pull request
Mar 3, 2019
It was halved by #1587 and later broken by their custom-element-based buttons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1586