Add hide-disabled-milestone-sorter feature

[kevin940726]

Closes #1918

Hide disabled milestone sorter

• Tested in chrome
• Tested in firefox

Example: https://github.com/ForkIssues/TrackerWin/milestone/9

[fregante]

I think you can do this with CSS:

[aria-label="You do not have permission to edit this milestone."] {
  display: none !important;
}

This CSS still leaves an area that triggers the grab cursor though. Perhaps that's ok.

Alternatively, this CSS can be extended so:

• only the icon is hidden
• the span with the tooltip is extended to the whole grab area and it will still show the tooltip.

Essentially it will hide the icon without also hiding the reason why it can't be sorted.

[kevin940726]

@bfred-it

I've thought about, but I didn't think that showing the cursor is acceptable. If it in fact is the preferred way then I'm happy to make the change!

[fregante]

The cursor isn't ideal, but I'd personally rather have that instead of more JS

[kevin940726]

@bfred-it
I just thought of a way to hack the cursor in my current implementation. I just have to assign a cursor: default to the <span> tag inside the grab area, then it should successfully cover all the area hence block the grab cursor from showing. Do you think it's a good idea?

[fregante]

Yeah that works for me, if it's easy to reposition the SVG in there

[fregante]

#1983 is in, please merge from master and add it as a extra file ^_^

[fregante]

The readme should probably link to #1918

[sindresorhus]

I find it weird that the tooltip just shows up when hovering over nothing. It also looks weird that the issue icon/titled is left indented so much.

[kevin940726]

@sindresorhus @bfred-it

My original implementation doesn't show the tooltip and the issue title is not indented. Should we revert back to it? Or is there any other alternative solution? Either way I'm here to help!

[sindresorhus]

My original implementation doesn't show the tooltip and the issue title is not indented. Should we revert back to it?

👍

[fregante]

Sorry for the mess 😅

As a last change, I'd like to see a mockup like this in the readme:

I usually copy-paste that exact before/after style:

[kevin940726]

@bfred-it Just updated the screenshot above. I'm not sure I followed here, do you mean to replace the issue link in readme.md to the image link? Or anything else?

[fregante]

Readme, instead of the link to the issue

[fregante]

Thanks for this feature and sorry for all the "suggestions" 🎠