Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align and rename release-download-count #2139

Merged
merged 2 commits into from Jun 9, 2019
Merged

Align and rename release-download-count #2139

merged 2 commits into from Jun 9, 2019

Conversation

fregante
Copy link
Member

@fregante fregante commented Jun 9, 2019

Fixes #2126
Closes #2136

Tested on https://github.com/electron/electron/releases

Numbers should be right-aligned and the label (in this case the icon) should be on the right as well, to follow the alignment. The size has the same alignment and the label ("MB", "KB", etc... is also on the right)

@fregante fregante changed the title Align asset download counts Align and rename release-download-count Jun 9, 2019
@fregante fregante merged commit 43a3ec4 into master Jun 9, 2019
@fregante fregante deleted the align-asset-count branch June 9, 2019 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Vertically align the asset download counts in releases
1 participant