Meta: Clean up webpack config file

[fregante]

This extracts code and checks unrelated to the build to its own file.

Ideally, separately, the actual checks would be completely separate from webpack. They'd require this same file, but they wouldn't throw errors.

[yakov116]

@fregante can you update webpack too? I tried updating and I was unable to build

[fregante]

It was webpack-contrib/css-loader#1284

[yakov116]

Unrelated question. Why is this needed?

[fregante]

Don't ask me!

I think I tried moving globals to the root and use it there but it didn't work…

[yakov116]

Does build need to be added here?

https://github.com/sindresorhus/refined-github/blob/a34191037be2ce5ad44ca6cc7015f71c8c8a7b19/tsconfig.json#L11-L14

If yes, once your at it "octicon-svg-loader.ts" can be removed

[yakov116]

Untested but looks good.

Want to regenerate the lock?

[fregante]

It’s ok for now since only select dev dependencies have been updated, we don’t have to do it every time.

[yakov116]

It’s ok for now since only select dev dependencies have been updated, we don’t have to do it every time.

I got burned from this so many times. I wish I would know the reason, but since we switched to npm 15 every time I do an update if I don't delete and start over, 💥.

Probably has to do with my machine. 🤷

[fregante]

Yeah it does happen but I supposed that if it works on CI it works for everyone. Usually they're peer dependency errors where babel stuff got updated partially and it's not fully compatible across versions.

[fregante]

Tested both build and watch

[yakov116]

Me too :)

Just a heads up I really learned from this PR. How you put the code together so simply and understandable.

I look at the code and I think to myself "ya maybe one day..."

Side Note: When do you sleep?!

[fregante]

When do you sleep?!

I recently moved across 12 timezones. I might have normalized my sleep schedule for now 😂

[yakov116]

I was wondering!