-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shorten version number #677
Conversation
From 17.8.20.834 to 17.8.20
Wouldn't this prevent us from doing manual urgent bug fix releases? (If it already had done an automatic release the same day) |
It would. If needed the code in #595 would solve that issue. But then I thought... when would it ever be necessary to ship Refined GitHub now instead of within 24 hours? |
If some changes on GitHub caused Refined GitHub to totally break, we would want to ship a fix right away. Could easily happen as we're playing on someone else's lawn. |
Understandable, but #675 totally broke the extension and it's gone unfixed for 20 hours. 😜 |
@bfred-it I did not know about that: #675 (comment) Can you message me on Twitter if you notice before me next time? And I'll fix it right away. |
via bfred-it/daily-version
713f2d0
to
5fea8ed
Compare
Ok, this now addresses your concern and closes #595 :) |
Shouldn't |
Chrome doesn't follow semver, it only allows integers: https://developer.chrome.com/extensions/manifest/version |
It looks like I hit a roadblock though. I have to store the cache somewhere else because travis only retrieves at Do you know of a free REST service that allows to store small data? In daily-version I'd replace cat ~/.npm-daily-version/v # get
echo "$CURR" > ~/.npm-daily-version/v # set with curl example.com/d2daaab2b2a6eprivatedaaab2b2a6e
curl example.com/d2daaab2b2a6eprivatedaaab2b2a6e -X POST -d $CURR Like http://myjson.com/api but not JSON or like http://www.kvstore.io/ but without login. 😅 |
Isn't that overkill just to get a slightly shorter version number that probably no one will even see? |
So let us just drop those badges. I don't see the point of them, to be honest. Alternatively, we could move them into a |
I find them useful to check what's the latest release (I think it appears on the chrome store almost instantly?) and if has already been approved on AMO. Thus, when something doesn't work (but AMO lags behind once again) I can check if the bug has already been fixed (and just didn't reach me yet) before I'm creating an issue. |
You could also check this in a |
Sure, I could, no problem. Just please don't remove them entirely :) |
I'd rather have them there, it's always one-click away to check if both versions have been published and they don't bother me that much 😁 |
Closes #595
Travis has been behaving well and deployments happening in the middle of UTC day, so same-day deployments are far from possible — even if that does happen we only lose a day anyway.