Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add participant username as title to reactions avatars #875

Merged
merged 3 commits into from Dec 15, 2017

Conversation

lukaszklis
Copy link
Contributor

Currently in order to see who has reacted on GitHub, you have to either know which avatar belongs to who, or check the link’s preview in Chrome in the bottom left corner. Why not exposing it as the link’s title, so it would be visible when hovering over the avatar? ;)

@fregante
Copy link
Member

I wouldn't mind this, but it'd have to use aria-label with classes .tooltipped.rgh-tooltipped instead of a regular title

@lukaszklis
Copy link
Contributor Author

@bfred-it true! I’ll adjust the code

@lukaszklis
Copy link
Contributor Author

🎉

@sindresorhus sindresorhus merged commit 9c0350e into refined-github:master Dec 15, 2017
@sindresorhus
Copy link
Member

Thanks :)

@lukaszklis lukaszklis deleted the names-reaction-avatars branch December 16, 2017 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants